Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimum scheduler age before task-creation-check #612

Merged

Conversation

thesuperzapper
Copy link
Member

What issues does your PR fix?

  • N/A

What does your PR do?

  • Currently, the scheduler can be killed by the "task creation check" before it actually had time to schedule a task, this PR adds scheduler.livenessProbe.taskCreationCheck.schedulerAgeBeforeCheck (default: 180), which defines the minimum scheduler age (seconds from the start_date of the SchedulerJob) before we start checking for task creation.

Checklist

For all Pull Requests

For releasing ONLY

Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <thesuperzapper@users.noreply.github.com>
@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Jun 21, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 21, 2022
@thesuperzapper thesuperzapper changed the title fix: wait for scheduler age before task-creation-check feat: wait for scheduler age before task-creation-check Jun 22, 2022
@thesuperzapper thesuperzapper changed the title feat: wait for scheduler age before task-creation-check feat: minimum scheduler age before task-creation-check Jun 22, 2022
@thesuperzapper thesuperzapper merged commit afcbe79 into airflow-helm:main Jun 22, 2022
@thesuperzapper thesuperzapper deleted the task-creation-check-fix branch June 22, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant